Skip to content

feat: add lapack/base/dlagts - #13800

Open
iampratik13 wants to merge 3 commits into
stdlib-js:developfrom
iampratik13:lapack/dlagts
Open

feat: add lapack/base/dlagts#13800
iampratik13 wants to merge 3 commits into
stdlib-js:developfrom
iampratik13:lapack/dlagts

Conversation

@iampratik13

@iampratik13 iampratik13 commented Jul 31, 2026

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: passed
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add lapack/base/dlagts

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@iampratik13
feat: add lapack/base/dlagts
06db4ab 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@iampratik13
iampratik13 requested a review from a team July 31, 2026 09:01
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Jul 31, 2026
@stdlib-bot

stdlib-bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlagts $\\color{green}496/496$
$\\color{green}+0.00\\%$ 		$\\color{green}71/71$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}496/496$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@iampratik13 iampratik13 added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels Jul 31, 2026
anandkaranubc and others added 2 commits July 31, 2026 23:05
@anandkaranubc
Merge branch 'develop' into lapack/dlagts
ae822fa
@anandkaranubc
chore: code review
2a765d2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc

anandkaranubc commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@iampratik13 I made some updates to the PR. Can you please review those and confirm if those are correct?

@iampratik13

iampratik13 commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

@anandkaranubc Thanks! I reviewed the latest updates, and everything looks correct to me.

@anandkaranubc

anandkaranubc commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@iampratik13 Are you positive that there are no similar changes here that were done in dlaruv after it was reviewed by Athan? I would suggest giving it another look again if you haven't yet. Thanks!

@iampratik13

iampratik13 commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

@anandkaranubc Yes, I’m sure. I reviewed it again, and it looks good to me.

@anandkaranubc
anandkaranubc requested a review from kgryte August 2, 2026 17:28
@anandkaranubc

anandkaranubc commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@anandkaranubc Yes, I’m sure. I reviewed it again, and it looks good to me.

Awesome thanks!

kgryte
kgryte reviewed Aug 3, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dlagts/lib/base.js
}
// Apply the transposed unit lower bidiagonal matrix `L^T` and the permutation `P`...
for ( k = N; k >= 2; k-- ) {
iy = offsetY + ( (k-1)*strideY );

@kgryte kgryte Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you doing this sort of repeated arithmetic expression?

Before entering the loop, precompute the initial iy, ii, ic. Then, at the end of the loop, decrement the pointers by the strides. You're doing 3 arithmetic operations per loop iteration, but you only need to be doing one.

That applies above, as well. You have all these inline expressions for pointers. Most of those can go away with clean code practices.

cc @anandkaranubc

@kgryte kgryte Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to see this cleaned up before doing a further review.

kgryte
kgryte reviewed Aug 3, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dlagts/lib/base.js
}
}
// Apply the transposed unit lower bidiagonal matrix `L^T` and the permutation `P`...
for ( k = N; k >= 2; k-- ) {

@kgryte kgryte Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we starting from k = N and then doing k - 1 below? That seems like a Fortran one-based indexing translation. Set k = N-1 and then you can avoid k-1. k is not used anywhere else in the loop beside pointer arithmetic. But also, this should go away once you fix your arithmetic expressions.

kgryte
kgryte requested changes Aug 3, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes
@anandkaranubc anandkaranubc Awaiting requested review from anandkaranubc

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iampratik13 @stdlib-bot @anandkaranubc @kgryte